From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmPfo-0006fR-Sq for qemu-devel@nongnu.org; Thu, 28 Jul 2011 08:26:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmPfo-0006qo-20 for qemu-devel@nongnu.org; Thu, 28 Jul 2011 08:26:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmPfn-0006qi-Qd for qemu-devel@nongnu.org; Thu, 28 Jul 2011 08:26:44 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6SCQhU1015547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Jul 2011 08:26:43 -0400 Date: Thu, 28 Jul 2011 15:27:15 +0300 From: "Michael S. Tsirkin" Message-ID: <20110728122715.GB29902@redhat.com> References: <20110728110605.GA29288@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Amit Shah , qemu list On Thu, Jul 28, 2011 at 02:21:32PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: > >> I hate the virtio pointer thicket. > > > > The problem is that each device is both a virtio pci > > device and a virtio net device. > > In my possibly naive opinion, virtio-FOO-pci is a PCI device, and has a > common virtio part. Yes, but it also has a comon virtio-pci part with other virtio-FOO-pci devices, and a common virtio-net part with virtio-net-XXXX. -- MST