From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Christoph Hellwig <hch@lst.de>,
Frediano Ziglio <freddy77@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation
Date: Fri, 29 Jul 2011 16:24:14 +0200 [thread overview]
Message-ID: <20110729142414.GA7665@lst.de> (raw)
In-Reply-To: <4E3158DE.2010404@redhat.com>
On Thu, Jul 28, 2011 at 02:41:02PM +0200, Kevin Wolf wrote:
> > More or less. There's one corner case for all Linux I/O, and that is
> > only writes up to INT_MAX are supported, and larger writes (and reads)
> > get truncated to it. It's pretty nasty, but Linux has been vocally
> > opposed to fixing this issue.
>
> I think we can safely ignore this. So just replacing the current
> ret = -EINVAL; by a memset(buf + ret, 0, len - ret); ret = 0; should be
> okay, right? (Of course using the qiov versions, but you get the idea)
This should be safe.
next prev parent reply other threads:[~2011-07-29 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 18:25 [Qemu-devel] [PATCH 0/2] improve Linux AIO support Frediano Ziglio
2011-07-27 18:25 ` [Qemu-devel] [PATCH 1/2] linux aio: support flush operation Frediano Ziglio
2011-07-27 18:31 ` Christoph Hellwig
2011-07-27 19:52 ` Frediano Ziglio
2011-07-27 19:57 ` Christoph Hellwig
2011-07-28 7:47 ` Kevin Wolf
2011-07-28 12:15 ` Christoph Hellwig
2011-07-28 12:41 ` Kevin Wolf
2011-07-29 14:24 ` Christoph Hellwig [this message]
2011-07-29 15:33 ` Stefan Hajnoczi
2011-07-27 18:25 ` [Qemu-devel] [PATCH 2/2] aio: use Linux AIO even if nocache is not specified Frediano Ziglio
2011-07-27 18:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729142414.GA7665@lst.de \
--to=hch@lst.de \
--cc=freddy77@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).