From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53270)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qnpe6-0003U2-Em
	for qemu-devel@nongnu.org; Mon, 01 Aug 2011 06:22:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qnpe5-0003kg-Fd
	for qemu-devel@nongnu.org; Mon, 01 Aug 2011 06:22:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19724)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qnpe5-0003kb-65
	for qemu-devel@nongnu.org; Mon, 01 Aug 2011 06:22:49 -0400
Date: Mon, 1 Aug 2011 13:23:22 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110801102322.GF5439@redhat.com>
References: <1312135082-31985-1-git-send-email-avi@redhat.com>
	<1312135082-31985-21-git-send-email-avi@redhat.com>
	<20110801082600.GD5439@redhat.com> <4E367370.6070100@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E367370.6070100@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On Mon, Aug 01, 2011 at 12:35:44PM +0300, Avi Kivity wrote:
> On 08/01/2011 11:26 AM, Michael S. Tsirkin wrote:
> >>
> >>   static void virtio_write_config(PCIDevice *pci_dev, uint32_t address,
> >>                                   uint32_t val, int len)
> >>   {
> >>       VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
> >>  +    VirtIODevice *vdev = proxy->vdev;
> >>
> >>       if (PCI_COMMAND == address) {
> >>           if (!(val&  PCI_COMMAND_MASTER)) {
> >>  @@ -525,6 +503,9 @@ static void virtio_write_config(PCIDevice *pci_dev, uint32_t address,
> >>               }
> >>           }
> >>       }
> >>  +    if (address == PCI_BASE_ADDRESS_0&&  vdev->config_len) {
> >>  +        vdev->get_config(vdev, vdev->config);
> >>  +    }
> >>
> >>       pci_default_write_config(pci_dev, address, val, len);
> >>       msix_write_config(pci_dev, address, val, len);
> >
> >I'm not really sure why did we get the config on map,
> >specifically - Anthony, do you know?
> >But if we want to do that, memory space enable might
> >be a better place. Or maybe we just want a callback on
> >map.
> 
> 
> Just because a memory region becomes visible to the cpu is no reason
> to have a callback.  From the device perspective, it can't tell that
> it happened.

Well, the reason we have this logic here, I think, is
to make sure it runs before the guest accesses
the configuration with a write access.

I'm not sure why we don't do this in the init
callback - Anthony?


> -- 
> error compiling committee.c: too many arguments to function