qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ryan Harper <ryanh@us.ibm.com>
To: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com,
	stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org,
	mtosatti@redhat.com, qemu-devel@nongnu.org, zwu.kernel@gmail.com,
	luowenj@cn.ibm.com, raharper@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4 0/3] The intro for QEMU disk I/O limits
Date: Mon, 1 Aug 2011 15:06:22 -0500	[thread overview]
Message-ID: <20110801200622.GL7358@us.ibm.com> (raw)
In-Reply-To: <1312179955-23536-1-git-send-email-wuzhy@linux.vnet.ibm.com>

* Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> [2011-08-01 01:30]:
> The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know.
> 
> The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue for each I/O limits enabled drive.
> 
> When a block request is coming in, the throttling algorithm will check if its I/O rate or counts exceed the limits; if yes, then it will enqueue to the block queue; The timer will handle the I/O requests in it.
> 
> Some available features follow as below:
> (1) global bps limit.
>     -drive bps=xxx            in bytes/s
> (2) only read bps limit
>     -drive bps_rd=xxx         in bytes/s
> (3) only write bps limit
>     -drive bps_wr=xxx         in bytes/s
> (4) global iops limit
>     -drive iops=xxx           in ios/s
> (5) only read iops limit
>     -drive iops_rd=xxx        in ios/s
> (6) only write iops limit
>     -drive iops_wr=xxx        in ios/s
> (7) the combination of some limits.
>     -drive bps=xxx,iops=xxx
> 
> Known Limitations:
> (1) #1 can not coexist with #2, #3
> (2) #4 can not coexist with #5, #6
> (3) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario.
> 
> 
> Zhi Yong Wu (3):
>   v4: fix memory leaking based on ryan's feedback. 

It looks like the leak has been fixed, but I think we need to rework how
the blk-queue is using the AIOPool.  I'll reply to that patch.



-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com

  parent reply	other threads:[~2011-08-01 20:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01  6:25 [Qemu-devel] [PATCH v4 0/3] The intro for QEMU disk I/O limits Zhi Yong Wu
2011-08-01  6:25 ` [Qemu-devel] [PATCH v4 1/3] The cmd support for QEMU block I/O throttling Zhi Yong Wu
2011-08-01  6:25 ` [Qemu-devel] [PATCH v4 2/3] The support for block queue Zhi Yong Wu
2011-08-01 20:21   ` Ryan Harper
2011-08-05  2:57     ` Zhi Yong Wu
2011-08-01  6:25 ` [Qemu-devel] [PATCH v4 3/3] The support for queue timer and throttling algorithm Zhi Yong Wu
2011-08-01 20:39   ` Ryan Harper
2011-08-05  2:48     ` Zhi Yong Wu
2011-08-01 20:06 ` Ryan Harper [this message]
2011-08-05  2:20   ` [Qemu-devel] [PATCH v4 0/3] The intro for QEMU disk I/O limits Zhi Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110801200622.GL7358@us.ibm.com \
    --to=ryanh@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=luowenj@cn.ibm.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=raharper@us.ibm.com \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=wuzhy@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).