qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [0.15][PATCH] lm32: softusb: claim to support full speed
Date: Mon, 1 Aug 2011 23:44:26 +0200	[thread overview]
Message-ID: <201108012344.26839.michael@walle.cc> (raw)
In-Reply-To: <1311274344-8720-1-git-send-email-michael@walle.cc>

Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  hw/milkymist-softusb.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
> index ce2bfc6..abf7b59 100644
> --- a/hw/milkymist-softusb.c
> +++ b/hw/milkymist-softusb.c
> @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
>      usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
> 
>      /* our two ports */
> +    /* FIXME: claim to support full speed devices. qemu mouse and keyboard
> +     * report themselves as full speed devices. */
>      usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
> -            USB_SPEED_MASK_LOW);
> +            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
>      usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
> -            USB_SPEED_MASK_LOW);
> +            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
> 
>      /* and finally create an usb keyboard */
>      s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");

Ping. Without this patch the whole milkymist target is non-functional in the 
0.15 release.

-- 
Michael

  parent reply	other threads:[~2011-08-01 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21 18:52 [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed Michael Walle
2011-07-26 22:01 ` Michael Walle
2011-08-01 21:44 ` Michael Walle [this message]
2011-08-03 13:17 ` Gerd Hoffmann
2011-08-03 23:36   ` Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108012344.26839.michael@walle.cc \
    --to=michael@walle.cc \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).