From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qo0Hj-0006os-CG for qemu-devel@nongnu.org; Mon, 01 Aug 2011 17:44:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qo0Hi-0003ii-AM for qemu-devel@nongnu.org; Mon, 01 Aug 2011 17:44:27 -0400 Received: from mail.serverraum.org ([78.47.150.89]:40934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qo0Hi-0003ia-5b for qemu-devel@nongnu.org; Mon, 01 Aug 2011 17:44:26 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.serverraum.org (Postfix) with ESMTP id 4AAE83EF4C for ; Mon, 1 Aug 2011 23:47:27 +0200 (CEST) Received: from mail.serverraum.org ([127.0.0.1]) by localhost (web.serverraum.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WvH1jqATiAuJ for ; Mon, 1 Aug 2011 23:47:27 +0200 (CEST) Received: from thanatos.localnet (95-89-251-205-dynip.superkabel.de [95.89.251.205]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.serverraum.org (Postfix) with ESMTPSA id 1AF9C3EF4B for ; Mon, 1 Aug 2011 23:47:26 +0200 (CEST) From: Michael Walle Date: Mon, 1 Aug 2011 23:44:26 +0200 References: <1311274344-8720-1-git-send-email-michael@walle.cc> In-Reply-To: <1311274344-8720-1-git-send-email-michael@walle.cc> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201108012344.26839.michael@walle.cc> Subject: [Qemu-devel] [0.15][PATCH] lm32: softusb: claim to support full speed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle: > The QEMU keyboard and mouse reports themselves as full speed devices, > though they are actually low speed devices. Until this is fixed, claim that > we are supporting full speed devices. > > Signed-off-by: Michael Walle > --- > hw/milkymist-softusb.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c > index ce2bfc6..abf7b59 100644 > --- a/hw/milkymist-softusb.c > +++ b/hw/milkymist-softusb.c > @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev) > usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL); > > /* our two ports */ > + /* FIXME: claim to support full speed devices. qemu mouse and keyboard > + * report themselves as full speed devices. */ > usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops, > - USB_SPEED_MASK_LOW); > + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); > usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops, > - USB_SPEED_MASK_LOW); > + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); > > /* and finally create an usb keyboard */ > s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd"); Ping. Without this patch the whole milkymist target is non-functional in the 0.15 release. -- Michael