From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QodWU-0002ht-UB
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 11:38:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QodWT-0002mJ-Mw
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 11:38:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40490)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QodWT-0002m9-ER
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 11:38:17 -0400
Date: Wed, 3 Aug 2011 18:38:53 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110803153853.GB16088@redhat.com>
References: <1312135082-31985-1-git-send-email-avi@redhat.com>
	<1312135082-31985-21-git-send-email-avi@redhat.com>
	<20110801082600.GD5439@redhat.com> <4E367370.6070100@redhat.com>
	<20110801102322.GF5439@redhat.com>
	<20110803151635.GA15804@redhat.com> <4E3967FD.8000301@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E3967FD.8000301@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On Wed, Aug 03, 2011 at 06:23:41PM +0300, Avi Kivity wrote:
> On 08/03/2011 06:16 PM, Michael S. Tsirkin wrote:
> >>
> >>  Well, the reason we have this logic here, I think, is
> >>  to make sure it runs before the guest accesses
> >>  the configuration with a write access.
> >>
> >>  I'm not sure why we don't do this in the init
> >>  callback - Anthony?
> >
> >So the following should do this.
> >Anthony, could you ack please?
> >
> >Avi, this is on top of the memory API branch.
> >But since it's not exactly the same,
> >maybe this should go in *before* the memory API
> >patches, to make it easier to bisect etc?
> >
> >You decide.
> 
> How can I decide?  This is your area.
> 
> I'll be happy to rebase if needed.

OK, I've sent a patch, pls stick it on your branch
and your changes can go on top. Thanks!

> -- 
> error compiling committee.c: too many arguments to function