From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoeMg-0002tQ-JT for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:32:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoeMf-0007K8-FX for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:32:14 -0400 Received: from verein.lst.de ([213.95.11.211]:54967 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoeMf-0007K3-4o for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:32:13 -0400 Date: Wed, 3 Aug 2011 18:32:12 +0200 From: Christoph Hellwig Message-ID: <20110803163212.GB8411@lst.de> References: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> <1312361359-15445-2-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312361359-15445-2-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Wed, Aug 03, 2011 at 10:49:04AM +0200, Paolo Bonzini wrote: > In fact, if the HBA's transfer_data callback goes on with scsi_req_continue > the request will be completed successfully instead of showing a failure. > It can even cause a segmentation fault. > > An easy way to trigger it is "eject -f cd" during installation (during media > test if the installer does something like that). > > Signed-off-by: Paolo Bonzini Looks good, Reviewed-by: Christoph Hellwig