From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoeN8-0003t6-F3 for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:32:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoeN7-0007MQ-JN for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:32:42 -0400 Received: from verein.lst.de ([213.95.11.211]:54971 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoeN7-0007MM-D0 for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:32:41 -0400 Date: Wed, 3 Aug 2011 18:32:41 +0200 From: Christoph Hellwig Message-ID: <20110803163241.GC8411@lst.de> References: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> <1312361359-15445-3-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312361359-15445-3-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 02/16] vscsi: always use get_sense List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Wed, Aug 03, 2011 at 10:49:05AM +0200, Paolo Bonzini wrote: > vscsi supports autosensing by providing sense data directly in the > response. When get_sense was added, the older state machine approach > that sent REQUEST SENSE commands separately was left in place. Remove > it, all existing SCSIDevices do support autosensing and the next patches > will make the support come for free from the SCSIBus. > > Signed-off-by: Paolo Bonzini Looks good, Reviewed-by: Christoph Hellwig