From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoeOP-0005Ai-RV for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:34:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoeOO-0007a0-Mf for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:34:01 -0400 Received: from verein.lst.de ([213.95.11.211]:54975 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoeOO-0007Zt-9j for qemu-devel@nongnu.org; Wed, 03 Aug 2011 12:34:00 -0400 Date: Wed, 3 Aug 2011 18:34:00 +0200 From: Christoph Hellwig Message-ID: <20110803163359.GD8411@lst.de> References: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> <1312361359-15445-4-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312361359-15445-4-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 03/16] scsi: pass status when completing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Wed, Aug 03, 2011 at 10:49:06AM +0200, Paolo Bonzini wrote: > A small improvement in the SCSI request API. Pass the status > at the time the request is completed, so that we can assert that > no request is completed twice. This would have detected the > problem fixed in the previous patch. > > Signed-off-by: Paolo Bonzini Looks good, Reviewed-by: Christoph Hellwig