From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1QolB4-0001eq-5b
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 19:48:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1QolB3-0006dt-5b
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 19:48:42 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:33610)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1QolB3-0006di-3S
	for qemu-devel@nongnu.org; Wed, 03 Aug 2011 19:48:41 -0400
Received: by qyk10 with SMTP id 10so2703403qyk.4
	for <qemu-devel@nongnu.org>; Wed, 03 Aug 2011 16:48:39 -0700 (PDT)
Date: Wed, 3 Aug 2011 19:48:37 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20110803234837.GA3596@morn.localdomain>
References: <20110707235009.GB12991@morn.localdomain>
	<87fwmh9puv.fsf@nemi.mork.no>
	<20110710204100.GA25495@morn.localdomain>
	<0895461378D74EC49BD787BDBFF8C934@FSCPC>
	<CAAMC3--fuYniyx55MhtddfRAj9PrVUfZXw2fLX+k5mMC-2W53w@mail.gmail.com>
	<8739hlb5t4.fsf@nemi.mork.no>
	<20110802003637.GA3046@morn.localdomain>
	<87y5zc9mzu.fsf@nemi.mork.no>
	<20110802124114.GA29924@morn.localdomain>
	<87pqkm7jko.fsf@nemi.mork.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87pqkm7jko.fsf@nemi.mork.no>
Subject: Re: [Qemu-devel] [SeaBIOS] SeaBIOS error with Juniper FreeBSD kernel
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Bj=F8rn?= Mork <bjorn@mork.no>
Cc: Brandon Bennett <bennetb@gmail.com>, seabios@seabios.org, qemu-devel@nongnu.org, Sebastian Herbszt <herbszt@gmx.de>

On Wed, Aug 03, 2011 at 02:42:15PM +0200, Bjørn Mork wrote:
>But what if additional data is added to
> the table, making f-segment allocation fail?  Then you will end up with
> three different results depending on small changes instead of two:
> 
>  1) nCPU <= 16 and f-segment allocation OK: SMBIOS in f-segment
>  2) nCPU > 16: SMBIOS in high mem
>  3) nCPU <= 16 and f-segment allocation failed: no SMBIOS table

If a reasonable limit is placed on the size of the SMBIOS table then
in practice the allocation will always succeed.

All of the f-segment allocations with the exception of the mptable are
small.  The mptable allocation should probably have an upper bound
placed on it as well.  There's currently 2048 bytes reserved for
malloc_fseg (CONFIG_MAX_BIOSTABLE), and the current smbios uses 263
bytes with one cpu and 938 bytes with 16 cpus (memory size may also
change size slightly).

-Kevin