From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/qdev: Don't crash if qdev_create(NULL, ...) fails
Date: Thu, 4 Aug 2011 10:15:09 +0100 [thread overview]
Message-ID: <20110804091509.GA29895@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1312411744-9292-1-git-send-email-peter.maydell@linaro.org>
On Wed, Aug 03, 2011 at 11:49:04PM +0100, Peter Maydell wrote:
> If an attempt to create a qdev device on the default sysbus (by passing
> NULL as the bus to qdev_create) fails, print a useful error message
> rather than crashing trying to dereference a NULL pointer.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/qdev.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next
Stefan
prev parent reply other threads:[~2011-08-04 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 22:49 [Qemu-devel] [PATCH] hw/qdev: Don't crash if qdev_create(NULL, ...) fails Peter Maydell
2011-08-04 6:55 ` Markus Armbruster
2011-08-04 9:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804091509.GA29895@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).