From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qp22N-0001MX-S4
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 13:48:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qp22M-000079-Mm
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 13:48:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46879)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qp22M-000074-CB
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 13:48:50 -0400
Date: Thu, 4 Aug 2011 14:48:41 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110804144841.481b935c@doriath>
In-Reply-To: <1312376904-16115-21-git-send-email-armbru@redhat.com>
References: <1312376904-16115-1-git-send-email-armbru@redhat.com>
	<1312376904-16115-21-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 20/45] ide: Provide IDEDeviceInfo method
	exit()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, quintela@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, hare@suse.de, amit.shah@redhat.com, hch@lst.de

On Wed,  3 Aug 2011 15:07:59 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/ide/internal.h |    1 +
>  hw/ide/qdev.c     |   12 ++++++++++++
>  2 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/ide/internal.h b/hw/ide/internal.h
> index 3e56b45..0b0b8a7 100644
> --- a/hw/ide/internal.h
> +++ b/hw/ide/internal.h
> @@ -529,6 +529,7 @@ typedef int (*ide_qdev_initfn)(IDEDevice *dev);
>  struct IDEDeviceInfo {
>      DeviceInfo qdev;
>      ide_qdev_initfn init;
> +    ide_qdev_initfn exit;
>  };
>  
>  #define BM_STATUS_DMAING 0x01
> diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
> index 6bd8d20..3b7b306 100644
> --- a/hw/ide/qdev.c
> +++ b/hw/ide/qdev.c
> @@ -91,9 +91,21 @@ err:
>      return -1;
>  }
>  
> +static int ide_qdev_exit(DeviceState *qdev)
> +{
> +    IDEDevice *dev = DO_UPCAST(IDEDevice, qdev, qdev);
> +    IDEDeviceInfo *info = DO_UPCAST(IDEDeviceInfo, qdev, qdev->info);
> +
> +    if (info->exit) {
> +        return info->exit(dev);
> +    }
> +    return 0;

return info->exit ? info->exit(dev) : 0;

> +}
> +
>  static void ide_qdev_register(IDEDeviceInfo *info)
>  {
>      info->qdev.init = ide_qdev_init;
> +    info->qdev.exit = ide_qdev_exit;
>      info->qdev.bus_info = &ide_bus_info;
>      qdev_register(&info->qdev);
>  }