From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qp2f2-0007oH-AV
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 14:28:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qp2f0-0000Fl-Vu
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 14:28:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38027)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qp2f0-0000Fa-Lh
	for qemu-devel@nongnu.org; Thu, 04 Aug 2011 14:28:46 -0400
Date: Thu, 4 Aug 2011 15:28:38 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110804152838.4a3c0145@doriath>
In-Reply-To: <m339hhqboo.fsf@blackfin.pond.sub.org>
References: <1312376904-16115-1-git-send-email-armbru@redhat.com>
	<1312376904-16115-41-git-send-email-armbru@redhat.com>
	<20110804151003.3adf1b24@doriath>
	<m339hhqboo.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign()
 in block.h, not block_int.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, quintela@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, hare@suse.de, amit.shah@redhat.com, hch@lst.de

On Thu, 04 Aug 2011 20:22:15 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Wed,  3 Aug 2011 15:08:19 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Device models should be able to use it without an unclean include of
> >> block_int.h.
> >
> > Nitpick: I'd do the prototype move after patch 38/45 and include the
> > block_int.h removal in the patch you're trimming block_int.h includes.
> 
> Care to explain why?

Seems more logical to me to solve the dependencies one by one and then
drop the includes in one shot. Maybe could even be done in a different
series.