From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33233)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QqPNI-0004VX-St
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:56:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QqPNI-0008Bu-3P
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:56:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43806)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QqPNH-0008B1-QN
	for qemu-devel@nongnu.org; Mon, 08 Aug 2011 08:56:08 -0400
Date: Mon, 8 Aug 2011 15:56:47 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110808125647.GA27643@redhat.com>
References: <1312463195-13605-1-git-send-email-avi@redhat.com>
	<1312463195-13605-2-git-send-email-avi@redhat.com>
	<4E3BF599.4050207@codemonkey.ws>
	<20110808103606.GA10372@redhat.com>
	<4E3FDA5F.5050105@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E3FDA5F.5050105@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Mon, Aug 08, 2011 at 07:45:19AM -0500, Anthony Liguori wrote:
> On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote:
> >>Thinking more closely, I don't think this right.
> >>
> >>Updating on map ensured that the config was refreshed after each
> >>time the bar was mapped.  In the very least, the config needs to be
> >>refreshed during reset because the guest may write to the guest
> >>space which should get cleared after reset.
> >>
> >>Regards,
> >>
> >>Anthony Liguori
> >
> >Not sure I understand. Which register, for example,
> >do you have in mind?
> >Could you clarify please?
> 
> Actually, you never need to call config_get() AFAICT.  It's called
> in every read/write access.

Every read, yes. But every write? Are you sure?

>  So I think the code you changed is
> extraneous now.
> 
> Regards,
> 
> Anthony Liguori


-- 
MST