* [Qemu-devel] [PATCH] lance: unbreak after memory API conversion
@ 2011-08-09 6:54 Avi Kivity
2011-08-09 7:01 ` Edgar E. Iglesias
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2011-08-09 6:54 UTC (permalink / raw)
To: qemu-devel; +Cc: kvm
The conversion passed the wrong opaque pointer, causing a crash on first use.
Pass the correct opaque.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/lance.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/lance.c b/hw/lance.c
index 8e20360..d83e7f5 100644
--- a/hw/lance.c
+++ b/hw/lance.c
@@ -116,7 +116,7 @@ static int lance_init(SysBusDevice *dev)
SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);
PCNetState *s = &d->state;
- memory_region_init_io(&s->mmio, &lance_mem_ops, s, "lance-mmio", 4);
+ memory_region_init_io(&s->mmio, &lance_mem_ops, d, "lance-mmio", 4);
qdev_init_gpio_in(&dev->qdev, parent_lance_reset, 1);
--
1.7.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] lance: unbreak after memory API conversion
2011-08-09 6:54 [Qemu-devel] [PATCH] lance: unbreak after memory API conversion Avi Kivity
@ 2011-08-09 7:01 ` Edgar E. Iglesias
0 siblings, 0 replies; 2+ messages in thread
From: Edgar E. Iglesias @ 2011-08-09 7:01 UTC (permalink / raw)
To: Avi Kivity; +Cc: qemu-devel, kvm
On Tue, Aug 09, 2011 at 09:54:22AM +0300, Avi Kivity wrote:
> The conversion passed the wrong opaque pointer, causing a crash on first use.
> Pass the correct opaque.
I've applied this, thanks.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> hw/lance.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/lance.c b/hw/lance.c
> index 8e20360..d83e7f5 100644
> --- a/hw/lance.c
> +++ b/hw/lance.c
> @@ -116,7 +116,7 @@ static int lance_init(SysBusDevice *dev)
> SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);
> PCNetState *s = &d->state;
>
> - memory_region_init_io(&s->mmio, &lance_mem_ops, s, "lance-mmio", 4);
> + memory_region_init_io(&s->mmio, &lance_mem_ops, d, "lance-mmio", 4);
>
> qdev_init_gpio_in(&dev->qdev, parent_lance_reset, 1);
>
> --
> 1.7.5.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-09 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-09 6:54 [Qemu-devel] [PATCH] lance: unbreak after memory API conversion Avi Kivity
2011-08-09 7:01 ` Edgar E. Iglesias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).