From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45980)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qqmcp-0007sV-HT
	for qemu-devel@nongnu.org; Tue, 09 Aug 2011 09:45:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qqmck-0004Jj-UB
	for qemu-devel@nongnu.org; Tue, 09 Aug 2011 09:45:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qqmck-00041n-CS
	for qemu-devel@nongnu.org; Tue, 09 Aug 2011 09:45:38 -0400
Date: Tue, 9 Aug 2011 15:42:47 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110809124246.GF524@redhat.com>
References: <1312808972-1718-1-git-send-email-avi@redhat.com>
	<1312808972-1718-27-git-send-email-avi@redhat.com>
	<4E40D9F3.5080309@mc.net> <4E40D921.9080700@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E40D921.9080700@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Bob Breuer <breuerr@mc.net>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On Tue, Aug 09, 2011 at 09:52:17AM +0300, Avi Kivity wrote:
> On 08/09/2011 09:55 AM, Bob Breuer wrote:
> >>   static void lance_cleanup(VLANClientState *nc)
> >>  @@ -117,13 +116,11 @@ static int lance_init(SysBusDevice *dev)
> >>       SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);
> >>       PCNetState *s =&d->state;
> >>
> >>  -    s->mmio_index =
> >>  -        cpu_register_io_memory(lance_mem_read, lance_mem_write, d,
> >>  -                               DEVICE_NATIVE_ENDIAN);
> >>  +    memory_region_init_io(&s->mmio,&lance_mem_ops, s, "lance-mmio", 4);
> >
> >You've switched up d and s here, so anything that tries to talk to the
> >ethernet, such as a sparc32 guest, will now cause Qemu to segfault.
> >
> >
> 
> Good catch; will post a fix.
> 
> Maybe keeping the opaque wasn't such a good idea.

Yes, we typically can get from the mmio to the device state
using container_of.

> -- 
> I have a truly marvellous patch that fixes the bug which this
> signature is too narrow to contain.