From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qqp9R-0000gD-FE for qemu-devel@nongnu.org; Tue, 09 Aug 2011 12:27:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qqp9P-0008NI-I7 for qemu-devel@nongnu.org; Tue, 09 Aug 2011 12:27:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qqp9P-0008N0-0r for qemu-devel@nongnu.org; Tue, 09 Aug 2011 12:27:31 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p79GRTsM020889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Aug 2011 12:27:29 -0400 Received: from bow.redhat.com (vpn-203-210.tlv.redhat.com [10.35.203.210]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p79GRPWc010636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Tue, 9 Aug 2011 12:27:29 -0400 Date: Tue, 9 Aug 2011 19:26:53 +0300 From: Alon Levy Message-ID: <20110809162653.GD3771@bow.redhat.com> References: <1312892475-20237-1-git-send-email-alevy@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312892475-20237-1-git-send-email-alevy@redhat.com> Subject: Re: [Qemu-devel] [PATCH] hw/qxl: fir build break with newer spice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, Aug 09, 2011 at 03:21:15PM +0300, Alon Levy wrote: > ioport_write's val was changed from uint32_t to uint64_t, this > broke two printfs. Use PRId64 instead of %d. Nack, missed a 'd' on the second fix. And the subject has a typo. > > Signed-off-by: Alon Levy > --- > hw/qxl.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/qxl.c b/hw/qxl.c > index db7ae7a..2335e4b 100644 > --- a/hw/qxl.c > +++ b/hw/qxl.c > @@ -1189,7 +1189,7 @@ async_common: > } > d->current_async = orig_io_port; > qemu_mutex_unlock(&d->async_lock); > - dprint(d, 2, "start async %d (%d)\n", io_port, val); > + dprint(d, 2, "start async %d (%"PRId64")\n", io_port, val); > break; > default: > break; > @@ -1305,7 +1305,8 @@ async_common: > break; > } > case QXL_IO_FLUSH_SURFACES_ASYNC: > - dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) (%s, s#=%d, res#=%d)\n", > + dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC" > + " (%"PRId64"d) (%s, s#=%d, res#=%d)\n", > val, qxl_mode_to_string(d->mode), d->guest_surfaces.count, > d->num_free_res); > qxl_spice_flush_surfaces_async(d); > -- > 1.7.6 > >