qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: agraf@suse.de
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Bug in recent CFAR patch
Date: Wed, 10 Aug 2011 15:22:42 +1000	[thread overview]
Message-ID: <20110810052242.GP23511@yookeroo.fritz.box> (raw)

Hi Alex,

I realised there was a bug in the CFAR patch in my recent qemu patch
series which breaks the build for ppc32 targets.

There is a patch to fix it below, but I'm not sure if you want this
standalone, or if you'd prefer I fold it into the CFAR patch replacing
the one you have now.

Please advise :)

>From 44096d5c32d3d4de2a6d600dc5d8c1539e79c85d Mon Sep 17 00:00:00 2001
From: David Gibson <david@gibson.dropbear.id.au>
Date: Fri, 5 Aug 2011 16:49:45 +1000
Subject: [PATCH] Fixup for 32-bit compile errors due to CFAR

---
 target-ppc/translate_init.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 510d9dd..35ce8bf 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -130,6 +130,7 @@ static void spr_write_lr (void *opaque, int sprn, int gprn)
 }
 
 /* CFAR */
+#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY)
 static void spr_read_cfar (void *opaque, int gprn, int sprn)
 {
     tcg_gen_mov_tl(cpu_gpr[gprn], cpu_cfar);
@@ -139,6 +140,7 @@ static void spr_write_cfar (void *opaque, int sprn, int gprn)
 {
     tcg_gen_mov_tl(cpu_cfar, cpu_gpr[gprn]);
 }
+#endif /* defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) */
 
 /* CTR */
 static void spr_read_ctr (void *opaque, int gprn, int sprn)
-- 
1.7.5.4



-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

             reply	other threads:[~2011-08-10  5:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  5:22 David Gibson [this message]
2011-08-10  8:01 ` [Qemu-devel] Bug in recent CFAR patch Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810052242.GP23511@yookeroo.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).