From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qr4Dj-0004Is-JF for qemu-devel@nongnu.org; Wed, 10 Aug 2011 04:33:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qr4Di-00037l-Fu for qemu-devel@nongnu.org; Wed, 10 Aug 2011 04:32:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qr4Di-00037P-8K for qemu-devel@nongnu.org; Wed, 10 Aug 2011 04:32:58 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7A8WuqA018440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Aug 2011 04:32:56 -0400 Date: Wed, 10 Aug 2011 11:32:19 +0300 From: Alon Levy Message-ID: <20110810083219.GF5637@bow.redhat.com> References: <1312923215-11824-1-git-send-email-alevy@redhat.com> <1312923215-11824-2-git-send-email-alevy@redhat.com> <4E422B2C.6090405@redhat.com> <20110810074329.GE5637@bow.redhat.com> <4E423D13.70106@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E423D13.70106@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] ui/spice-core: report version in 'info spice' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Wed, Aug 10, 2011 at 10:10:59AM +0200, Gerd Hoffmann wrote: > Hi, > > >>I think it would also be nice to somehow hint this is the spice > >sent a second patch (fixing the above), but didn't do any hinting. I'll send a third. > > Saw v2. I would just stick a "version" string into the dict instead > of the three values for major, minor and micro. > Argh. Sent v3 with the three ints. Do you prefer a single version? > >>version qemu was compiled against. The shared library which is > >>actually used might be newer. > > > >I thought of this problem but decided it's better to at least have the compiled > >version (getting the linked against version is not hard, but I'd rather > >not force to do it at this moment - I guess via dlopen. Which is linux specific - > >will need yet another wrapper for that api to compile on windows). > > The compiled version is perfectly fine, I think it is more useful to > have that one as it decides which features qemu is able to use. > Just completeness :) I'm not going to do it right now anyway. > If we want report the runtime version too (any reason to do this?) > I'd just add a spice_server_get_version() function to the library. > > cheers, > Gerd >