From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qrcmo-0006bo-JH for qemu-devel@nongnu.org; Thu, 11 Aug 2011 17:27:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qrcmn-0004Vo-2W for qemu-devel@nongnu.org; Thu, 11 Aug 2011 17:27:30 -0400 Received: from ch1ehsobe001.messaging.microsoft.com ([216.32.181.181]:41726 helo=ch1outboundpool.messaging.microsoft.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qrcmm-0004VQ-Ud for qemu-devel@nongnu.org; Thu, 11 Aug 2011 17:27:29 -0400 Date: Thu, 11 Aug 2011 16:27:15 -0500 From: Scott Wood Message-ID: <20110811212715.GA28821@schlenkerla.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Subject: [Qemu-devel] [PATCH] qcow: initialize coroutine mutex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alexander Graf commit 52b8eb60132b27ad53476490e9d7579003390cfa added a mutex, but never initialized it. This caused a segfault. Reported-by: Alexander Graf Signed-off-by: Scott Wood --- block/qcow.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 6447c2a..e46f15f 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -159,6 +159,8 @@ static int qcow_open(BlockDriverState *bs, int flags) goto fail; bs->backing_file[len] = '\0'; } + + qemu_co_mutex_init(&s->lock); return 0; fail: -- 1.7.6