From: Stefan Hajnoczi <stefanha@gmail.com>
To: Devin Nakamura <devin122@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qed: make qed_alloc_clusters round up offset to nearest cluster
Date: Tue, 16 Aug 2011 17:22:43 +0100 [thread overview]
Message-ID: <20110816162243.GA19697@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1313450170-22646-1-git-send-email-devin122@gmail.com>
On Mon, Aug 15, 2011 at 07:16:10PM -0400, Devin Nakamura wrote:
> @@ -263,6 +263,8 @@ static int qed_read_string(BlockDriverState *file, uint64_t offset, size_t n,
> */
> static uint64_t qed_alloc_clusters(BDRVQEDState *s, unsigned int n)
> {
> + s->file_size = qed_start_of_cluster(s, s->file_size +
> + s->header.cluster_size - 1);
Why do you need this? QED cluster aligns the file size on open.
file_size should always be cluster-aligned.
Stefan
next prev parent reply other threads:[~2011-08-16 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 23:16 [Qemu-devel] [PATCH] qed: make qed_alloc_clusters round up offset to nearest cluster Devin Nakamura
2011-08-16 16:22 ` Stefan Hajnoczi [this message]
[not found] ` <CAJ1AwB5v8V-KMz7YK9xYuyXn6jWN+H23dXCn5EV1hsuS3iqgnQ@mail.gmail.com>
2011-08-16 18:03 ` Devin Nakamura
2011-08-23 12:38 ` Kevin Wolf
2011-08-25 9:33 ` Stefan Hajnoczi
2011-08-25 22:14 ` Devin Nakamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816162243.GA19697@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=devin122@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).