From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-img: print error codes when convert fails
Date: Thu, 18 Aug 2011 15:22:37 +0100 [thread overview]
Message-ID: <20110818142237.GA8239@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <4E4C0B39.4040702@redhat.com>
On Wed, Aug 17, 2011 at 08:40:57PM +0200, Kevin Wolf wrote:
> Am 17.08.2011 18:41, schrieb Stefan Hajnoczi:
> > Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Thanks, applied to the block branch.
>
> (But is it really helpful to include sector numbers in the error
> message? Especially since we're not reading/writing single sectors)
The intention is that it would show suspicious sectors numbers, e.g. ~2
GB or ~4 GB.
In the best case it saves a round-trip on a bug report. In the worst
case the sector number is a distraction :).
Stefan
prev parent reply other threads:[~2011-08-18 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 16:41 [Qemu-devel] [PATCH] qemu-img: print error codes when convert fails Stefan Hajnoczi
2011-08-17 18:40 ` Kevin Wolf
2011-08-18 14:22 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818142237.GA8239@stefanha-thinkpad.localdomain \
--to=stefanha@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).