From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target-cris/opcode-cris.h: rename REG_PC/SP to CRIS_REG_PC/SP
Date: Sat, 20 Aug 2011 01:43:01 +0200 [thread overview]
Message-ID: <20110819234301.GA30301@zapo> (raw)
In-Reply-To: <1313796424-10077-1-git-send-email-peter.maydell@linaro.org>
On Sat, Aug 20, 2011 at 12:27:04AM +0100, Peter Maydell wrote:
> The REG_PC constant used in opcode-cris.h can clash with a
> similar define in system include files. In particular the
> Ubuntu Lucid SPARC signal.h will define REG_PC, and since
> qemu-common.h now includes signal.h this was causing compile
> failures. Rename the constants to avoid this issue.
> (NB that REG_SP is not actually used within QEMU.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Applied, thanks Peter.
Cheers
prev parent reply other threads:[~2011-08-19 23:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 23:27 [Qemu-devel] [PATCH] target-cris/opcode-cris.h: rename REG_PC/SP to CRIS_REG_PC/SP Peter Maydell
2011-08-19 23:43 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819234301.GA30301@zapo \
--to=edgar.iglesias@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).