From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuYiS-0001AX-DS for qemu-devel@nongnu.org; Fri, 19 Aug 2011 19:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QuYiR-0001ZE-7U for qemu-devel@nongnu.org; Fri, 19 Aug 2011 19:43:08 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:59237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuYiR-0001ZA-2v for qemu-devel@nongnu.org; Fri, 19 Aug 2011 19:43:07 -0400 Received: by fxbb27 with SMTP id b27so2567843fxb.4 for ; Fri, 19 Aug 2011 16:43:06 -0700 (PDT) Date: Sat, 20 Aug 2011 01:43:01 +0200 From: "Edgar E. Iglesias" Message-ID: <20110819234301.GA30301@zapo> References: <1313796424-10077-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1313796424-10077-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH] target-cris/opcode-cris.h: rename REG_PC/SP to CRIS_REG_PC/SP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On Sat, Aug 20, 2011 at 12:27:04AM +0100, Peter Maydell wrote: > The REG_PC constant used in opcode-cris.h can clash with a > similar define in system include files. In particular the > Ubuntu Lucid SPARC signal.h will define REG_PC, and since > qemu-common.h now includes signal.h this was causing compile > failures. Rename the constants to avoid this issue. > (NB that REG_SP is not actually used within QEMU.) > > Signed-off-by: Peter Maydell Applied, thanks Peter. Cheers