From: Yann Dirson <ydirson@free.fr>
To: Johannes Schauer <j.schauer@email.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, Vagrant Cascadian <vagrant@freegeek.org>,
632192@bugs.debian.org
Subject: Re: [Qemu-devel] [PATCH] introduce environment variables for all qemu-user options
Date: Sat, 20 Aug 2011 19:29:47 +0200 [thread overview]
Message-ID: <20110820172947.GD30636@home.lan> (raw)
In-Reply-To: <1312613652-19977-1-git-send-email-j.schauer@email.de>
This patch will be useful, but there is a security problem in its
current form. The qemu-user-static package installs binfmt-misc
entries with "flags: OC", which makes the binary honor setuid bits.
Regardless of whether it is a good idea or not, the envvars ought to
be ignored in such a case. Some clever checks using getresuid(), or
just geteuid() and getuid() when getresuid() is not available, surely
have to done. There is probably some existing code for this in other
programs...
Best regards,
--
Yann
prev parent reply other threads:[~2011-08-20 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 5:47 [Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable josch
2011-07-23 5:47 ` josch
2011-07-28 8:41 ` Riku Voipio
2011-07-28 11:24 ` Johannes Schauer
2011-07-28 16:50 ` Geert Stappers
2011-07-28 17:28 ` Alexander Graf
2011-07-29 12:52 ` [Qemu-devel] Bug#632192: " Vagrant Cascadian
2011-07-29 15:21 ` Johannes Schauer
2011-07-30 13:58 ` Riku Voipio
2011-07-31 11:51 ` [Qemu-devel] [PATCH] introduce environment variables for all qemu-user options j.schauer
2011-07-31 12:12 ` Peter Maydell
2011-07-31 21:40 ` Johannes Schauer
2011-08-05 10:04 ` Peter Maydell
2011-08-06 6:54 ` Johannes Schauer
2011-08-20 17:29 ` Yann Dirson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110820172947.GD30636@home.lan \
--to=ydirson@free.fr \
--cc=632192@bugs.debian.org \
--cc=j.schauer@email.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=vagrant@freegeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).