From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amdragon@mit.edu>) id 1QvD4s-00028P-9T
	for qemu-devel@nongnu.org; Sun, 21 Aug 2011 14:48:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amdragon@mit.edu>) id 1QvD4q-0000qy-PX
	for qemu-devel@nongnu.org; Sun, 21 Aug 2011 14:48:58 -0400
Received: from dmz-mailsec-scanner-4.mit.edu ([18.9.25.15]:49593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amdragon@mit.edu>) id 1QvD4q-0000qs-Mt
	for qemu-devel@nongnu.org; Sun, 21 Aug 2011 14:48:56 -0400
Date: Sun, 21 Aug 2011 14:48:38 -0400
From: Austin Clements <amdragon@MIT.EDU>
Message-ID: <20110821184838.GP21339@mit.edu>
References: <1313378361-15610-1-git-send-email-amdragon@mit.edu>
	<CAAu8pHsUv0z03D-ZFrHUmquX6yNgFi_6zLThbGN06bPJqh-gtA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
In-Reply-To: <CAAu8pHsUv0z03D-ZFrHUmquX6yNgFi_6zLThbGN06bPJqh-gtA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] monitor: Prevent sign-extension of 32-bit
 addresses printed by info mem
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Quoth Blue Swirl on Aug 21 at  6:26 pm:
> On Mon, Aug 15, 2011 at 3:19 AM, Austin Clements <amdragon@mit.edu> wrote:
> > Previously, on 32-bit i386, info mem used signed 32-bit int's to store
> > the page table indexes. =A0As a result, address calculation was done in
> > 32 bits and then incorrectly sign-extended to 64 bits, yielding output
> > like
> >
> > ffffffffef000000-ffffffffef031000 0000000000031000 ur-
> > ffffffffef7bc000-ffffffffef7bd000 0000000000001000 urw
> > ffffffffef7bd000-ffffffffef7be000 0000000000001000 ur-
> >
> > This makes these indexes unsigned, which yields correct output
> >
> > 00000000ef000000-00000000ef031000 0000000000031000 ur-
> > 00000000ef7bc000-00000000ef7bd000 0000000000001000 urw
> > 00000000ef7bd000-00000000ef7be000 0000000000001000 ur-
> >
> > Signed-off-by: Austin Clements <amdragon@mit.edu>
> 
> Thanks, applied. I think 'info tlb' needs a similar fix.

Quite right.  I'll follow up with the info tlb patch.