* [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data
@ 2011-07-28 12:01 Alon Levy
0 siblings, 0 replies; 6+ messages in thread
From: Alon Levy @ 2011-07-28 12:01 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Alon Levy <alevy@redhat.com>
---
libcacard/Makefile | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 15205b5..33c1302 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -56,9 +56,8 @@ install-libcacard: libcacard.pc libcacard.la vscclient
$(INSTALL_DIR) "$(DESTDIR)$(bindir)"
libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
- libtool --mode=install $(INSTALL_PROG) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
+ libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
for inc in *.h; do \
- libtool --mode=install $(INSTALL_PROG) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
+ libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
done
-
endif
--
1.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data
2011-08-13 21:23 [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data Brad
@ 2011-08-13 0:04 ` Alon Levy
2011-08-22 17:34 ` Brad
1 sibling, 0 replies; 6+ messages in thread
From: Alon Levy @ 2011-08-13 0:04 UTC (permalink / raw)
To: Brad; +Cc: qemu-devel
On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote:
> libcacard: use INSTALL_DATA for data
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
>
Thanks, I'll add it to the next pull request.
> ---
> libcacard/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 5cd7594..fe9747a 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -54,7 +54,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient
> $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
> $(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> - libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
> + libtool --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
> libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
> for inc in *.h; do \
> libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
> --
> 1.7.6
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data
@ 2011-08-13 21:23 Brad
2011-08-13 0:04 ` Alon Levy
2011-08-22 17:34 ` Brad
0 siblings, 2 replies; 6+ messages in thread
From: Brad @ 2011-08-13 21:23 UTC (permalink / raw)
To: qemu-devel
libcacard: use INSTALL_DATA for data
Signed-off-by: Brad Smith <brad@comstyle.com>
---
libcacard/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 5cd7594..fe9747a 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -54,7 +54,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient
$(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
$(INSTALL_DIR) "$(DESTDIR)$(bindir)"
libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
- libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
+ libtool --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
for inc in *.h; do \
libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
--
1.7.6
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data
2011-08-13 21:23 [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data Brad
2011-08-13 0:04 ` Alon Levy
@ 2011-08-22 17:34 ` Brad
2011-09-02 10:10 ` Stefan Hajnoczi
1 sibling, 1 reply; 6+ messages in thread
From: Brad @ 2011-08-22 17:34 UTC (permalink / raw)
To: qemu-devel
On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote:
> libcacard: use INSTALL_DATA for data
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
>
> ---
> libcacard/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 5cd7594..fe9747a 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -54,7 +54,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient
> $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
> $(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> - libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
> + libtool --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
> libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
> for inc in *.h; do \
> libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
> --
> 1.7.6
An updated diff against up to date master.
libcacard: use INSTALL_DATA for data
Signed-off-by: Brad Smith <brad@comstyle.com>
---
libcacard/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index b3f5e6c..bd7b3e6 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -56,7 +56,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient
$(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
$(INSTALL_DIR) "$(DESTDIR)$(bindir)"
$(LIBTOOL) --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
- $(LIBTOOL) --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
+ $(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
$(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
for inc in *.h; do \
$(LIBTOOL) --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
--
1.7.6
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data
2011-08-22 17:34 ` Brad
@ 2011-09-02 10:10 ` Stefan Hajnoczi
2011-09-02 10:45 ` Alon Levy
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Hajnoczi @ 2011-09-02 10:10 UTC (permalink / raw)
To: Brad; +Cc: qemu-devel
On Mon, Aug 22, 2011 at 01:34:57PM -0400, Brad wrote:
> On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote:
> > libcacard: use INSTALL_DATA for data
> >
> > Signed-off-by: Brad Smith <brad@comstyle.com>
> >
> > ---
> > libcacard/Makefile | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/libcacard/Makefile b/libcacard/Makefile
> > index 5cd7594..fe9747a 100644
> > --- a/libcacard/Makefile
> > +++ b/libcacard/Makefile
> > @@ -54,7 +54,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient
> > $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
> > $(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> > libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> > - libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
> > + libtool --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
> > libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
> > for inc in *.h; do \
> > libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
> > --
> > 1.7.6
>
> An updated diff against up to date master.
>
>
> libcacard: use INSTALL_DATA for data
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
>
> ---
> libcacard/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data
2011-09-02 10:10 ` Stefan Hajnoczi
@ 2011-09-02 10:45 ` Alon Levy
0 siblings, 0 replies; 6+ messages in thread
From: Alon Levy @ 2011-09-02 10:45 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel, Brad
On Fri, Sep 02, 2011 at 11:10:32AM +0100, Stefan Hajnoczi wrote:
> On Mon, Aug 22, 2011 at 01:34:57PM -0400, Brad wrote:
> > On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote:
> > > libcacard: use INSTALL_DATA for data
> > >
> > > Signed-off-by: Brad Smith <brad@comstyle.com>
> > >
> > > ---
> > > libcacard/Makefile | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/libcacard/Makefile b/libcacard/Makefile
> > > index 5cd7594..fe9747a 100644
> > > --- a/libcacard/Makefile
> > > +++ b/libcacard/Makefile
> > > @@ -54,7 +54,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient
> > > $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
> > > $(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> > > libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> > > - libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
> > > + libtool --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
> > > libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
> > > for inc in *.h; do \
> > > libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
> > > --
> > > 1.7.6
> >
> > An updated diff against up to date master.
> >
> >
> > libcacard: use INSTALL_DATA for data
> >
> > Signed-off-by: Brad Smith <brad@comstyle.com>
> >
> > ---
> > libcacard/Makefile | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Thanks, applied to the trivial patches tree:
> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
>
Thanks, my bad for not doing a pull request.
> Stefan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-02 10:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-13 21:23 [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data Brad
2011-08-13 0:04 ` Alon Levy
2011-08-22 17:34 ` Brad
2011-09-02 10:10 ` Stefan Hajnoczi
2011-09-02 10:45 ` Alon Levy
-- strict thread matches above, loose matches on Subject: below --
2011-07-28 12:01 Alon Levy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).