[Qemu-devel] [PATCH 1/2] xilinx.h: Added missing includes

[Qemu-devel] [PATCH 1/2] xilinx.h: Added missing includes

[Peter A. G. Crosthwaite]

Added some missing #includes for this file. Previously this file
relied on its clients to pre-include its dependencies.

Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
---
 hw/xilinx.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/xilinx.h b/hw/xilinx.h
index 090e6f7..3a1f4c6 100644
--- a/hw/xilinx.h
+++ b/hw/xilinx.h
@@ -1,3 +1,5 @@
+#include "qemu-common.h"
+#include "net.h"
 
 /* OPB Interrupt Controller.  */
 qemu_irq *microblaze_pic_init_cpu(CPUState *env);
-- 
1.7.3.2

[Qemu-devel] [PATCH 2/2] xilinx: removed microbalze_pic_init from xilinx.h

[Peter A. G. Crosthwaite]

This is a microblaze target specific function that belongs outside
of xilinx.h (which is a collection of target independent device model
instantiator functions)

Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
---
 hw/microblaze_pic_cpu.c       |    2 +-
 hw/microblaze_pic_cpu.h       |    8 ++++++++
 hw/petalogix_ml605_mmu.c      |    1 +
 hw/petalogix_s3adsp1800_mmu.c |    2 ++
 hw/xilinx.h                   |    3 ---
 5 files changed, 12 insertions(+), 4 deletions(-)
 create mode 100644 hw/microblaze_pic_cpu.h

diff --git a/hw/microblaze_pic_cpu.c b/hw/microblaze_pic_cpu.c
index 7c59382..9ad48b4 100644
--- a/hw/microblaze_pic_cpu.c
+++ b/hw/microblaze_pic_cpu.c
@@ -24,6 +24,7 @@
 
 #include "hw.h"
 #include "pc.h"
+#include "microblaze_pic_cpu.h"
 
 #define D(x)
 
@@ -43,7 +44,6 @@ static void microblaze_pic_cpu_handler(void *opaque, int irq, int level)
         cpu_reset_interrupt(env, type);
 }
 
-qemu_irq *microblaze_pic_init_cpu(CPUState *env);
 qemu_irq *microblaze_pic_init_cpu(CPUState *env)
 {
     return qemu_allocate_irqs(microblaze_pic_cpu_handler, env, 2);
diff --git a/hw/microblaze_pic_cpu.h b/hw/microblaze_pic_cpu.h
new file mode 100644
index 0000000..4c76275
--- /dev/null
+++ b/hw/microblaze_pic_cpu.h
@@ -0,0 +1,8 @@
+#ifndef MICROBLAZE_PIC_CPU_H
+#define MICROBLAZE_PIC_CPU_H
+
+#include "qemu-common.h"
+
+qemu_irq *microblaze_pic_init_cpu(CPUState *env);
+
+#endif /*  MICROBLAZE_PIC_CPU_H */
diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
index e3a66e5..e3ca310 100644
--- a/hw/petalogix_ml605_mmu.c
+++ b/hw/petalogix_ml605_mmu.c
@@ -39,6 +39,7 @@
 #include "blockdev.h"
 #include "pc.h"
 
+#include "microblaze_pic_cpu.h"
 #include "xilinx_axidma.h"
 
 #define LMB_BRAM_SIZE  (128 * 1024)
diff --git a/hw/petalogix_s3adsp1800_mmu.c b/hw/petalogix_s3adsp1800_mmu.c
index 589e8ca..a43fb4c 100644
--- a/hw/petalogix_s3adsp1800_mmu.c
+++ b/hw/petalogix_s3adsp1800_mmu.c
@@ -36,6 +36,8 @@
 #include "elf.h"
 #include "blockdev.h"
 
+#include "microblaze_pic_cpu.h"
+
 #define LMB_BRAM_SIZE  (128 * 1024)
 #define FLASH_SIZE     (16 * 1024 * 1024)
 
diff --git a/hw/xilinx.h b/hw/xilinx.h
index 3a1f4c6..35f35bd 100644
--- a/hw/xilinx.h
+++ b/hw/xilinx.h
@@ -1,9 +1,6 @@
 #include "qemu-common.h"
 #include "net.h"
 
-/* OPB Interrupt Controller.  */
-qemu_irq *microblaze_pic_init_cpu(CPUState *env);
-
 static inline DeviceState *
 xilinx_intc_create(target_phys_addr_t base, qemu_irq irq, int kind_of_intr)
 {
-- 
1.7.3.2

Re: [Qemu-devel] [PATCH 2/2] xilinx: removed microbalze_pic_init from xilinx.h

[Edgar E. Iglesias]

On Mon, Aug 22, 2011 at 06:15:25PM +1000, Peter A. G. Crosthwaite wrote:
> This is a microblaze target specific function that belongs outside
> of xilinx.h (which is a collection of target independent device model
> instantiator functions)

Applied both, thanks Peter.