From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: scottwood@freescale.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] PPC: E500: Inject SPE exception on invalid SPE access
Date: Tue, 23 Aug 2011 22:34:40 +0200 [thread overview]
Message-ID: <20110823203440.GA20917@zapo> (raw)
In-Reply-To: <1314075344-20839-3-git-send-email-agraf@suse.de>
On Tue, Aug 23, 2011 at 06:55:43AM +0200, Alexander Graf wrote:
> When accessing an SPE instruction despite it being not available,
> throw an SPE exception instead of an APU exception. That way the
> guest knows what's going on and actually uses SPE.
>
> Reported-by: Jason Wessel <jason.wessel@windriver.com>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> target-ppc/translate.c | 78 ++++++++++++++++++++++++------------------------
> 1 files changed, 39 insertions(+), 39 deletions(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index fd7c208..f36363a 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -6622,7 +6622,7 @@ static inline void gen_evmra(DisasContext *ctx)
> {
>
> if (unlikely(!ctx->spe_enabled)) {
> - gen_exception(ctx, POWERPC_EXCP_APU);
> + gen_exception(ctx, POWERPC_EXCP_SPEU);
> return;
> }
>
> @@ -6693,7 +6693,7 @@ static inline void gen_speundef(DisasContext *ctx)
> static inline void gen_##name(DisasContext *ctx) \
> { \
> if (unlikely(!ctx->spe_enabled)) { \
> - gen_exception(ctx, POWERPC_EXCP_APU); \
> + gen_exception(ctx, POWERPC_EXCP_SPEU); \
^^
I've applied this (with a minor whitespace change), thanks Alex.
Cheers
next prev parent reply other threads:[~2011-08-23 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 4:55 [Qemu-devel] [PATCH 0/3] PPC: E500: Support SPE guest Alexander Graf
2011-08-23 4:55 ` [Qemu-devel] [PATCH 1/3] PPC: E500: Add ESR bit definitions Alexander Graf
2011-08-23 4:55 ` [Qemu-devel] [PATCH 2/3] PPC: E500: Inject SPE exception on invalid SPE access Alexander Graf
2011-08-23 4:55 ` [Qemu-devel] [PATCH 3/3] PPC: E500: Set ESR values Alexander Graf
2011-08-23 20:34 ` Edgar E. Iglesias [this message]
2011-08-23 17:00 ` [Qemu-devel] [PATCH 0/3] PPC: E500: Support SPE guest Jason Wessel
2011-08-23 20:10 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823203440.GA20917@zapo \
--to=edgar.iglesias@gmail.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).