From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1QwIws-0001OX-Qy
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 15:17:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1QwIwr-0006CD-OO
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 15:17:14 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:57629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1QwIwr-0006C6-IO
	for qemu-devel@nongnu.org; Wed, 24 Aug 2011 15:17:13 -0400
Received: by bkbzv3 with SMTP id zv3so1272046bkb.4
	for <qemu-devel@nongnu.org>; Wed, 24 Aug 2011 12:17:12 -0700 (PDT)
Date: Wed, 24 Aug 2011 21:17:07 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20110824191707.GB18214@zapo>
References: <20110824183949.GC17167@zapo>
	<1314212981-30211-1-git-send-email-avi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1314212981-30211-1-git-send-email-avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] gt64xxx: fix crash in gt64120_pci_mapping()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On Wed, Aug 24, 2011 at 10:09:41PM +0300, Avi Kivity wrote:
> The map/unmap code was assymetric - unmap used the local MemoryRegion while
> map used isa_mmio_init(), which cannot handle dynamic mappings.
> 
> Fix by using isa_mmio_setup() and the local MemoryRegion.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>

Thanks, this works for me. I'll apply it in a moment.

Cheers