qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <dwg@au1.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel Developers <qemu-devel@nongnu.org>,
	thuth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data
Date: Thu, 25 Aug 2011 12:23:50 +1000	[thread overview]
Message-ID: <20110825022350.GL30097@yookeroo.fritz.box> (raw)
In-Reply-To: <286B9428-BF1B-4F56-A126-8FA337BF5643@suse.de>

On Wed, Aug 24, 2011 at 04:41:34PM -0500, Alexander Graf wrote:
> 
> On 24.08.2011, at 10:28, Paolo Bonzini wrote:
> 
> > I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
> > 2011-08-03) because at the time there was no way to expose a sense
> > condition to SLOF and Linux manages to work around the bug.  However,
> > the bug becomes evident now that SCSI devices also report unit
> > attention on reset.
> > 
> > SLOF also has problems dealing with unit attention conditions, so
> > it still will not boot even with this fix (just like OpenBIOS).
> > IBM folks are aware of their part of the bug. :-)
> 
> David, please ack.

Done.

We also need to get the updated SLOF into place, I can't remember how
we sent commits involving binary blobs previously.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2011-08-25  2:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 15:28 [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data Paolo Bonzini
2011-08-24 21:41 ` Alexander Graf
2011-08-25  2:23   ` David Gibson [this message]
2011-08-25  2:56     ` Alexander Graf
2011-08-25  1:18 ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110825022350.GL30097@yookeroo.fritz.box \
    --to=dwg@au1.ibm.com \
    --cc=agraf@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).