From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwUy0-0006m4-5h for qemu-devel@nongnu.org; Thu, 25 Aug 2011 04:07:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwUxz-0004h9-2L for qemu-devel@nongnu.org; Thu, 25 Aug 2011 04:07:12 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:63276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwUxy-0004gq-Qg for qemu-devel@nongnu.org; Thu, 25 Aug 2011 04:07:11 -0400 Received: by fxbb27 with SMTP id b27so1771114fxb.4 for ; Thu, 25 Aug 2011 01:07:09 -0700 (PDT) Date: Thu, 25 Aug 2011 09:06:57 +0100 From: Stefan Hajnoczi Message-ID: <20110825080657.GA7046@stefanha-thinkpad.localdomain> References: <1314172671-13123-1-git-send-email-peter.crosthwaite@petalogix.com> <20110824120826.GA4968@stefanha-thinkpad.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] qemu-coroutine: Add simple work queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: kwolf@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org On Thu, Aug 25, 2011 at 04:46:59PM +1000, Peter Crosthwaite wrote: > Hi Stefan, > > I have ccd you on a RFC containing the work that this patch uses. I have > also changed the name of the function to co_queue_enter_next() as i think > yield was not the appropriate name. The idea is the top level thread which > is managing the work queue can transfer into coroutine context with the > function, so this function is more of an "enter" function than a "yield" > function. I cant see any technical reasons why it needs the coroutine_fn > restriction, as this in not required by qemu_coroutine_enter, which is the > backend of this function. You are right, I was confused by the "yield" in the name :). It doesn't need to be coroutine_fn. Stefan