From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Raghavendra D Prabhu <rprabhu@wnohang.net>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Raghavendra D Prabhu <raghu.prabhu13@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions
Date: Thu, 25 Aug 2011 14:13:58 +0100 [thread overview]
Message-ID: <20110825131358.GG22456@redhat.com> (raw)
In-Reply-To: <CAFEAcA9ZVn59QmV-WFOMNqfw6ykF=auoEHKHttyFej9VJnFfmA@mail.gmail.com>
On Thu, Aug 25, 2011 at 01:27:00PM +0100, Peter Maydell wrote:
> On 25 August 2011 13:11, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> wrote:
> > From: Raghavendra D Prabhu <raghu.prabhu13@gmail.com>
> >
> > The gnutls_*_set_priority family of functions has been marked deprecated
> > in 2.12.x. These functions have been superceded by
> > gnutls_priority_set_direct().
>
> Does this constitute a change in the required version of gnutls which
> we need to document in the proto-changelog for the next release?
> Is it worth updating the configure tls check to check for this function
> so we fall back to no-tls if the system version is too old?
The gnutls_priority_set_direct() function has existed since 2.1.7 according
to the GNUTLS NEWS files.
Our configure check merely looks for 'gnutls.h' which will match any
gnutls 1.x or 2.x release, and I can currently build qemu with TLS
support on a RHEL-5 host which has gnutls 1.4.1
So I believe this change will significantly increase our min required
gnutls version. We could #ifdef the code to deal with this, or perhaps
do a patch based on use of gnutls_set_default_priority() which I
believe is available in both 1.x and 2.x and is not deprecated
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2011-08-25 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 12:11 [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions Stefan Hajnoczi
2011-08-25 12:27 ` Peter Maydell
2011-08-25 13:13 ` Daniel P. Berrange [this message]
2011-08-26 10:24 ` Peter Maydell
2011-08-26 12:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825131358.GG22456@redhat.com \
--to=berrange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=raghu.prabhu13@gmail.com \
--cc=rprabhu@wnohang.net \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).