From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwZky-0005uI-FZ for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:14:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwZkx-0004H1-0l for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:14:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwZkw-0004Gx-Ow for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:14:02 -0400 Date: Thu, 25 Aug 2011 14:13:58 +0100 From: "Daniel P. Berrange" Message-ID: <20110825131358.GG22456@redhat.com> References: <1314274278-19582-1-git-send-email-stefanha@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Raghavendra D Prabhu , Stefan Hajnoczi , Raghavendra D Prabhu , Anthony Liguori On Thu, Aug 25, 2011 at 01:27:00PM +0100, Peter Maydell wrote: > On 25 August 2011 13:11, Stefan Hajnoczi wrote: > > From: Raghavendra D Prabhu > > > > The gnutls_*_set_priority family of functions has been marked deprecated > > in 2.12.x. These functions have been superceded by > > gnutls_priority_set_direct(). > > Does this constitute a change in the required version of gnutls which > we need to document in the proto-changelog for the next release? > Is it worth updating the configure tls check to check for this function > so we fall back to no-tls if the system version is too old? The gnutls_priority_set_direct() function has existed since 2.1.7 according to the GNUTLS NEWS files. Our configure check merely looks for 'gnutls.h' which will match any gnutls 1.x or 2.x release, and I can currently build qemu with TLS support on a RHEL-5 host which has gnutls 1.4.1 So I believe this change will significantly increase our min required gnutls version. We could #ifdef the code to deal with this, or perhaps do a patch based on use of gnutls_set_default_priority() which I believe is available in both 1.x and 2.x and is not deprecated Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|