Re: [Qemu-devel] [PULL] Memory API conversions, batch 5

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Thu, Aug 25, 2011 at 02:02:24PM -0500, Anthony Liguori wrote:
> On 08/25/2011 01:58 PM, Blue Swirl wrote:
> >On Thu, Aug 25, 2011 at 6:27 PM, Edgar E. Iglesias
> ><edgar.iglesias@gmail.com>  wrote:
> >>On Thu, Aug 25, 2011 at 08:04:34AM -0500, Anthony Liguori wrote:
> >>>On 08/25/2011 03:01 AM, Avi Kivity wrote:
> >>>>Please pull from
> >>>>
> >>>>git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/batch
> >>>>
> >>>>to receive the fifth memory API conversions batch. There is really
> >>>>nothing notable, except perhaps the first use of the transaction API.
> >>>>
> >>>>While the patches have been on the list for just a short time, they have
> >>>>received quite extensive review, for which I am thankful.
> >>>
> >>>Pulled.  Thanks.
> >>
> >>Guys, please start testing before applying these patches. It's not hard,
> >>there are images on the wiki with scripts that area easy to run.
> >
> >It's also possible to revert offending patches. But a better solution
> >would be to have a comprehensive test setup to do builds and run
> >checks on selected trees. Before a pull to main tree, the test results
> >should be available.
> 
> Before a pull *request*.  Semantically, pull requests should be
> treated as a push.  It's the submaintainers responsibility to test
> the bits they do a pull request for.

Yup.

> That said, the logistics of testing a series like this is mind
> numbingly complex.  We really need to all work on better automation
> for this.  In the interim, I think we're just going to have to leave
> with occasional breakage from changes like this and make sure it
> doesn't happen too frequently.

Yes, I understand its not an easy to test all combinations. But there
are scripts that testrun various targets on the wiki. It doesnt take
long to run those. You can also explicitely ask for help with the testing.
I'm happy to assist if the test scripts dont run or if you CC me on
a testme request.

Avi's done a great job with these series, converting all targets and all.
I dont mean to misscredit that.

Cheers