From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwswI-0004MU-77 for qemu-devel@nongnu.org; Fri, 26 Aug 2011 05:43:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwswG-0005hE-Tj for qemu-devel@nongnu.org; Fri, 26 Aug 2011 05:43:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwswG-0005h2-I1 for qemu-devel@nongnu.org; Fri, 26 Aug 2011 05:43:00 -0400 Date: Fri, 26 Aug 2011 12:43:44 +0300 From: "Michael S. Tsirkin" Message-ID: <20110826094254.GA6520@redhat.com> References: <20110704094358.GA10960@redhat.com> <4E4B7DE1.3050405@cn.fujitsu.com> <4E4C8577.5000608@cn.fujitsu.com> <4E4D2C9F.6040805@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E4D2C9F.6040805@redhat.com> Subject: Re: [Qemu-devel] [PATCH] pci: add standard bridge device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Kevin Wolf , Isaku Yamahata , qemu-devel@nongnu.org On Thu, Aug 18, 2011 at 08:15:43AM -0700, Avi Kivity wrote: > It's correct but insufficient, the filtering code > (pci_bridge_filter) needs to be updated to use the memory API. > > Basically it gets simpler and correcter. I've been struggling with the following problem: bridges have two memory ranges: prefetcheable and non-prefetcheable. Memory in the device can be behind the prefetcheable and non-prefetcheable memory range, but things only work correctly if non-prefetcheable memory on the device is put behind a non-prefetcheable range. Prefetcheable memory can go anywhere I think. This didn't work correctly before the memory API change, but it was easy to fix ... Now I'm not sure how. -- MST