From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwt97-0007g6-UW for qemu-devel@nongnu.org; Fri, 26 Aug 2011 05:56:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qwt95-0007rY-4t for qemu-devel@nongnu.org; Fri, 26 Aug 2011 05:56:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qwt94-0007rU-S6 for qemu-devel@nongnu.org; Fri, 26 Aug 2011 05:56:15 -0400 Date: Fri, 26 Aug 2011 12:57:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20110826095700.GA6811@redhat.com> References: <20110704094358.GA10960@redhat.com> <4E4B7DE1.3050405@cn.fujitsu.com> <4E4C8577.5000608@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E4C8577.5000608@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH] pci: add standard bridge device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: Kevin Wolf , Isaku Yamahata , qemu-devel@nongnu.org, Avi Kivity On Thu, Aug 18, 2011 at 11:22:31AM +0800, Wen Congyang wrote: > >From 3ce0000e5a14f0ff7aeac148f9416eac6fa7c6ca Mon Sep 17 00:00:00 2001 > From: Wen Congyang > Date: Thu, 18 Aug 2011 09:33:19 +0800 > Subject: [PATCH] PCI_Bridge: use parent bus's address space > > The pci device may call pci_register_bar() to use PCI bus's address space. > But we forget to init PCI bus's address space if it is not bus 0. It will > cause qemu crashed. > > Signed-off-by: Wen Congyang I've applied this for now so we can make progress. > --- > hw/pci_bridge.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c > index 464d897..df16faa 100644 > --- a/hw/pci_bridge.c > +++ b/hw/pci_bridge.c > @@ -246,6 +246,8 @@ int pci_bridge_initfn(PCIDevice *dev) > br->bus_name); > sec_bus->parent_dev = dev; > sec_bus->map_irq = br->map_irq; > + sec_bus->address_space_mem = parent->address_space_mem; > + sec_bus->address_space_io = parent->address_space_io; > > QLIST_INIT(&sec_bus->child); > QLIST_INSERT_HEAD(&parent->child, sec_bus, sibling); > -- > 1.7.1