From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48158)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QwyvJ-00050f-8f
	for qemu-devel@nongnu.org; Fri, 26 Aug 2011 12:06:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1QwyvH-000758-Tu
	for qemu-devel@nongnu.org; Fri, 26 Aug 2011 12:06:25 -0400
Received: from verein.lst.de ([213.95.11.211]:34771 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QwyvH-00074v-O2
	for qemu-devel@nongnu.org; Fri, 26 Aug 2011 12:06:23 -0400
Date: Fri, 26 Aug 2011 18:06:22 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110826160622.GA21194@lst.de>
References: <20110821222547.GA22046@lst.de> <20110825062544.GA30579@lst.de>
	<20110825062610.GC30639@lst.de> <4E579A02.7090304@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E579A02.7090304@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] block: latency accounting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Fri, Aug 26, 2011 at 03:05:06PM +0200, Kevin Wolf wrote:
> The order of READ vs. WRITE is wrong here, so read latencies show up as
> wr_total_time. I can fix it locally if you agree that swapping the two
> lines is the right fix.

Yes, it got mixed up in one of the revamps.