From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxl76-0004IB-C6 for qemu-devel@nongnu.org; Sun, 28 Aug 2011 15:33:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qxl75-0008GA-8Q for qemu-devel@nongnu.org; Sun, 28 Aug 2011 15:33:48 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:52507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxl75-0008G6-3V for qemu-devel@nongnu.org; Sun, 28 Aug 2011 15:33:47 -0400 Received: by fxbb27 with SMTP id b27so4326845fxb.4 for ; Sun, 28 Aug 2011 12:33:46 -0700 (PDT) Date: Sun, 28 Aug 2011 21:33:42 +0200 From: "Edgar E. Iglesias" Message-ID: <20110828193342.GA7244@zapo> References: <1314546216-26613-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1314546216-26613-1-git-send-email-avi@redhat.com> Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, Richard Henderson On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. > > In order to get the correct opaque into the MemoryRegion object, the > allocation scheme is changed so that the flash emulation code allocates > memory, instead of the caller. This clears a FIXME in the flash code. Hi Avi, Something is going wrong with the flash devices. It can be reproduced with the microblaze image on the wiki, you'll see the kernel complain with: pflash_write: Unimplemented flash cmd sequence (offset 00000000, wcycle 0x0 cmd 0x0 value 0xf0) of-flash a0000000.flash: do_map_probe() failed When it should be saying: a0000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank. Manufacturer ID 0x000000 Chip ID 0x000000 Intel/Sharp Extended Query Table at 0x0031 Cheers