qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API
Date: Mon, 29 Aug 2011 08:04:51 +0200	[thread overview]
Message-ID: <20110829060451.GC3166@zapo> (raw)
In-Reply-To: <4E5B254E.9090204@redhat.com>

On Mon, Aug 29, 2011 at 08:36:14AM +0300, Avi Kivity wrote:
> On 08/28/2011 10:33 PM, Edgar E. Iglesias wrote:
> >On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote:
> >>  cfi02 is annoying in that is ignores some address bits; we probably
> >>  want explicit support in the memory API for that.
> >>
> >>  In order to get the correct opaque into the MemoryRegion object, the
> >>  allocation scheme is changed so that the flash emulation code allocates
> >>  memory, instead of the caller.  This clears a FIXME in the flash code.
> >
> >Hi Avi,
> >
> >Something is going wrong with the flash devices. It can be reproduced
> >with the microblaze image on the wiki, you'll see the kernel complain
> >with:
> >pflash_write: Unimplemented flash cmd sequence (offset 00000000, wcycle 0x0 cmd 0x0 value 0xf0)
> >of-flash a0000000.flash: do_map_probe() failed
> >
> >When it should be saying:
> >a0000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank. Manufacturer ID 0x000000 Chip ID 0x000000
> >Intel/Sharp Extended Query Table at 0x0031
> >
> >
> 
> I get exactly the same behaviour with upstream - 9f94778.  With what
> version does it work correctly?

Im on a slightly patched tree, will try clean upstream versions.
Maybe the flashes never worked with that board in upstream... :/

Cheers

  reply	other threads:[~2011-08-29  6:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-28 15:43 [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API Avi Kivity
2011-08-28 18:14 ` Edgar E. Iglesias
2011-08-28 18:46   ` Edgar E. Iglesias
2011-08-29  5:35   ` Avi Kivity
2011-08-28 19:33 ` Edgar E. Iglesias
2011-08-29  5:36   ` Avi Kivity
2011-08-29  6:04     ` Edgar E. Iglesias [this message]
2011-08-29  6:13     ` Edgar E. Iglesias
2011-08-28 20:37 ` Edgar E. Iglesias
2011-08-29  5:38   ` Avi Kivity
2011-08-29  6:00     ` Edgar E. Iglesias
2011-08-29  6:15       ` Avi Kivity
2011-08-29  6:18         ` Edgar E. Iglesias
2011-08-29  7:21         ` Avi Kivity
2011-08-29  7:30           ` Edgar E. Iglesias
2011-08-29  8:15             ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829060451.GC3166@zapo \
    --to=edgar.iglesias@gmail.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).