From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53337)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qxuxr-0005Rz-SN
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 02:04:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qxuxq-0007EM-QX
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 02:04:55 -0400
Received: from mail-fx0-f45.google.com ([209.85.161.45]:40984)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qxuxq-0007E9-M5
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 02:04:54 -0400
Received: by fxbb27 with SMTP id b27so4599952fxb.4
	for <qemu-devel@nongnu.org>; Sun, 28 Aug 2011 23:04:53 -0700 (PDT)
Date: Mon, 29 Aug 2011 08:04:51 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20110829060451.GC3166@zapo>
References: <1314546216-26613-1-git-send-email-avi@redhat.com>
	<20110828193342.GA7244@zapo> <4E5B254E.9090204@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E5B254E.9090204@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to
	memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On Mon, Aug 29, 2011 at 08:36:14AM +0300, Avi Kivity wrote:
> On 08/28/2011 10:33 PM, Edgar E. Iglesias wrote:
> >On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote:
> >>  cfi02 is annoying in that is ignores some address bits; we probably
> >>  want explicit support in the memory API for that.
> >>
> >>  In order to get the correct opaque into the MemoryRegion object, the
> >>  allocation scheme is changed so that the flash emulation code allocates
> >>  memory, instead of the caller.  This clears a FIXME in the flash code.
> >
> >Hi Avi,
> >
> >Something is going wrong with the flash devices. It can be reproduced
> >with the microblaze image on the wiki, you'll see the kernel complain
> >with:
> >pflash_write: Unimplemented flash cmd sequence (offset 00000000, wcycle 0x0 cmd 0x0 value 0xf0)
> >of-flash a0000000.flash: do_map_probe() failed
> >
> >When it should be saying:
> >a0000000.flash: Found 1 x8 devices at 0x0 in 8-bit bank. Manufacturer ID 0x000000 Chip ID 0x000000
> >Intel/Sharp Extended Query Table at 0x0031
> >
> >
> 
> I get exactly the same behaviour with upstream - 9f94778.  With what
> version does it work correctly?

Im on a slightly patched tree, will try clean upstream versions.
Maybe the flashes never worked with that board in upstream... :/

Cheers