From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qxwrg-00004v-KQ
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 04:06:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qxwrf-0008GW-Ky
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 04:06:40 -0400
Received: from mail-ew0-f45.google.com ([209.85.215.45]:40821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qxwrf-0008GN-Fi
	for qemu-devel@nongnu.org; Mon, 29 Aug 2011 04:06:39 -0400
Received: by ewy24 with SMTP id 24so2524927ewy.4
	for <qemu-devel@nongnu.org>; Mon, 29 Aug 2011 01:06:38 -0700 (PDT)
Date: Mon, 29 Aug 2011 09:30:22 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20110829073022.GA26574@edde.se.axis.com>
References: <1314546216-26613-1-git-send-email-avi@redhat.com>
	<20110828203715.GB7244@zapo> <4E5B25D2.1080402@redhat.com>
	<20110829060022.GB3166@zapo> <4E5B2E8C.9020006@redhat.com>
	<4E5B3DDF.8060008@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E5B3DDF.8060008@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to
	memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On Mon, Aug 29, 2011 at 10:21:03AM +0300, Avi Kivity wrote:
> On 08/29/2011 09:15 AM, Avi Kivity wrote:
> > On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote:
> >> >
> >> >  It does bite, as I saw with gdb.  You can even see that from the
> >> >  qemu error - it complains about unimplemented command 0xf0, that
> >> >  comes from pflash_write() later on.
> >>
> >> I wasn't clear enough maybe, the code in question is running, but the
> >> set_readble is not having any effect AFAICT. The reads, that
> >> should come through via IO callbacks when switching mode are
> >> not getting through. Do you ever see pflash_read beeing called?
> >>
> >
> > Thanks for the clarification.  I don't, and there is now a fix on
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git
> >
> 
> Forgot the branch:
> 
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git  fix-pflash


That works

Thanks