From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code
Date: Mon, 29 Aug 2011 12:39:57 +0100 [thread overview]
Message-ID: <20110829113957.GA6780@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1311188196-2867-1-git-send-email-weil@mail.berlios.de>
On Wed, Jul 20, 2011 at 08:56:35PM +0200, Stefan Weil wrote:
> cppcheck reports this error:
>
> qemu/hw/sh_intc.c:390: error: Possible null pointer dereference:
> s - otherwise it is redundant to check if s is null at line 385
>
> If s were NULL, the printf() statement would crash.
> Setting braces fixes this bug.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/sh_intc.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
prev parent reply other threads:[~2011-08-29 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 18:56 [Qemu-devel] [PATCH] sh4: Fix potential crash in debug code Stefan Weil
2011-07-20 18:56 ` [Qemu-devel] [PATCH] tcg/mips: Fix regression caused by typo (copy + paste bug) Stefan Weil
2011-07-25 10:22 ` [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code Stefan Hajnoczi
2011-08-13 9:25 ` [Qemu-devel] " Stefan Weil
2011-08-27 19:27 ` Stefan Weil
2011-08-28 11:13 ` Andreas Färber
2011-08-29 11:39 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829113957.GA6780@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).