From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy6v7-0007Om-T1 for qemu-devel@nongnu.org; Mon, 29 Aug 2011 14:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qy6v5-0000kc-LC for qemu-devel@nongnu.org; Mon, 29 Aug 2011 14:50:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy6v5-0000kD-A4 for qemu-devel@nongnu.org; Mon, 29 Aug 2011 14:50:51 -0400 Date: Mon, 29 Aug 2011 13:56:24 -0300 From: Marcelo Tosatti Message-ID: <20110829165624.GA3003@amt.cnet> References: <2e43e3a409b7fa5f4781e30f3d7b7e56aa5d1fb0.1314398066.git.udeshpan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e43e3a409b7fa5f4781e30f3d7b7e56aa5d1fb0.1314398066.git.udeshpan@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/5] Support for vm_stop from the migration thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Umesh Deshpande Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On Sat, Aug 27, 2011 at 02:09:44PM -0400, Umesh Deshpande wrote: > Currently, when any thread other than iothread calls vm_stop, it is scheduled to > be executed later by the iothread. This patch allows the execution of vm_stop > from threads other than iothread. This is especially helpful when the migration is > moved into a separate thread. > > Signed-off-by: Umesh Deshpande > --- > cpus.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/cpus.c b/cpus.c > index de70e02..f35f683 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -122,8 +122,8 @@ static void do_vm_stop(int reason) > { > if (vm_running) { > cpu_disable_ticks(); > - vm_running = 0; > pause_all_vcpus(); > + vm_running = 0; > vm_state_notify(0, reason); > qemu_aio_flush(); > bdrv_flush_all(); Why this change?