From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyfWl-0007zn-1p for qemu-devel@nongnu.org; Wed, 31 Aug 2011 03:48:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyfWj-0007gn-Un for qemu-devel@nongnu.org; Wed, 31 Aug 2011 03:48:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyfWj-0007gj-LQ for qemu-devel@nongnu.org; Wed, 31 Aug 2011 03:48:01 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7V7m0Xv018811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Aug 2011 03:48:00 -0400 Date: Wed, 31 Aug 2011 10:48:53 +0300 From: "Michael S. Tsirkin" Message-ID: <20110831074852.GA29379@redhat.com> References: <20110831074348.22973.7545.stgit@t> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110831074348.22973.7545.stgit@t> Subject: Re: [Qemu-devel] [PATCH] vhost: Fix typo in comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: qemu-devel@nongnu.org On Wed, Aug 31, 2011 at 03:43:48PM +0800, Amos Kong wrote: > vhost_dev_stop() and vhost_dev_disable_notifiers() are called in > vhost_net_stop(), correct this comment. > > Signed-off-by: Amos Kong > --- > hw/vhost.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/vhost.c b/hw/vhost.c > index 0870cb7..640aff0 100644 > --- a/hw/vhost.c > +++ b/hw/vhost.c > @@ -797,7 +797,7 @@ fail: > return r; > } > > -/* Host notifiers must be enabled at this point. */ > +/* Host notifiers must be disabled at this point. */ > void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev) > { > int i, r; Well it looks like we first call vhost_dev_stop and only afterwards vhost_dev_disable_notifiers. So when vhost_dev_stop is called notifiers are enabled, and they really must be otherwise stuff will fail. Isn't this what the original comment says? If that's not clear, what would be a better wording? -- MST