From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47250)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QzCAh-0004sJ-LN
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 14:39:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QzCAg-0004Xo-98
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 14:39:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50151)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QzCAg-0004WE-0p
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 14:39:26 -0400
Date: Thu, 1 Sep 2011 15:39:17 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110901153917.112c5428@doriath>
In-Reply-To: <4E5FCF61.4040404@siemens.com>
References: <1314900738-30164-1-git-send-email-lcapitulino@redhat.com>
	<1314900738-30164-4-git-send-email-lcapitulino@redhat.com>
	<4E5FCF61.4040404@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/8] RunState: Add additional states
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>, "amit.shah@redhat.com" <amit.shah@redhat.com>, "aliguori@us.ibm.com" <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "armbru@redhat.com" <armbru@redhat.com>

On Thu, 01 Sep 2011 20:30:57 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 2011-09-01 20:12, Luiz Capitulino wrote:
> > Currently, only vm_start() and vm_stop() change the VM state.
> > That's, the state is only changed when starting or stopping the VM.
> > 
> > This commit adds the runstate_set() function, which makes it possible
> > to also do state transitions when the VM is stopped or running.
> > 
> > Additional states are also added and the current state is stored.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  cpus.c      |    1 +
> >  migration.c |    8 +++++++-
> >  sysemu.h    |   10 +++++++++-
> >  vl.c        |   20 ++++++++++++++++++++
> >  4 files changed, 37 insertions(+), 2 deletions(-)
> > 
> 
> ...
> 
> > diff --git a/vl.c b/vl.c
> > index f0b56a4..59f71fc 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -321,6 +321,22 @@ static int default_driver_check(QemuOpts *opts, void *opaque)
> >  }
> >  
> >  /***********************************************************/
> > +/* QEMU state */
> > +
> > +static RunState current_run_state = RSTATE_NO_STATE;
> > +
> > +bool runstate_check(RunState state)
> > +{
> > +    return current_run_state == state;
> > +}
> > +
> > +void runstate_set(RunState state)
> > +{
> > +    assert(state < RSTATE_MAX);
> > +    current_run_state = state;
> 
> I still think this should check for valid state transitions instead of
> blindly accepting what the caller passes in.

I thought your comment where more like a future enhancement than
a request for change.

What to do if the transition is invalid? abort()?