From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzCVa-0005N9-NJ for qemu-devel@nongnu.org; Thu, 01 Sep 2011 15:01:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzCVa-0000gA-0C for qemu-devel@nongnu.org; Thu, 01 Sep 2011 15:01:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzCVZ-0000fm-Ib for qemu-devel@nongnu.org; Thu, 01 Sep 2011 15:01:01 -0400 Date: Thu, 1 Sep 2011 22:01:08 +0300 From: "Michael S. Tsirkin" Message-ID: <20110901190108.GA13378@redhat.com> References: <20110831143551.127339744@linux.vnet.ibm.com> <20110831143625.419705972@linux.vnet.ibm.com> <20110901181024.GJ10989@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110901181024.GJ10989@redhat.com> Subject: Re: [Qemu-devel] [PATCH V8 14/14] Allow to provide inital TPM state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: chrisw@redhat.com, anbang.ruan@cs.ox.ac.uk, qemu-devel@nongnu.org, rrelyea@redhat.com, alevy@redhat.com, andreas.niederl@iaik.tugraz.at, serge@hallyn.com On Thu, Sep 01, 2011 at 09:10:24PM +0300, Michael S. Tsirkin wrote: > Do we really have to hand-craft file reading? > How large is TPMPROP_TPM_MAX_NV_SPACE? > If not too large, we can just allocate that > and do a single fread call? > > Or, we rely on glib now - can we use > g_io_channel_read_to_end () or something like that? Or scanf 'a' conversion - it seems to be a gnu extension but we rely on gcc anyway.