qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <dwg@au1.ibm.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: aliguori@us.ibm.com, joerg.roedel@amd.com, qemu-devel@nongnu.org,
	agraf@suse.de, eduard.munteanu@linux360.ro, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 09/10] usb-ohci: Use PCI DMA stub functions
Date: Fri, 2 Sep 2011 11:47:52 +1000	[thread overview]
Message-ID: <20110902014752.GT11906@yookeroo.fritz.box> (raw)
In-Reply-To: <4E5F5A28.9040001@redhat.com>

On Thu, Sep 01, 2011 at 12:10:48PM +0200, Gerd Hoffmann wrote:
> On 09/01/11 07:01, David Gibson wrote:
> >From: Eduard - Gabriel Munteanu<eduard.munteanu@linux360.ro>
> >
> >This updates the usb-ohci device emulation to use the explicit PCI DMA
> >functions, instead of directly calling physical memory access functions.
> 
> It isn't that simple.
> 
> There are non-PCI ohci devices which I think you break with this
> patch.

Ah, good point.  I'll remove the OHCI patch from the next iteration of
this series, and fix it properly later with some of the other harder
cases like ne2k.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2011-09-02  1:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01  5:00 [Qemu-devel] [0/10] Preliminary work for IOMMU emulation support; the easy bits David Gibson
2011-09-01  5:00 ` [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA David Gibson
2011-09-01 15:35   ` Michael S. Tsirkin
2011-09-02  0:39     ` David Gibson
2011-09-02  4:38     ` David Gibson
2011-09-05  7:55       ` Michael S. Tsirkin
2011-09-01 15:55   ` Anthony Liguori
2011-09-01 16:03     ` Avi Kivity
2011-09-01 16:05       ` Anthony Liguori
2011-09-01 16:11         ` Avi Kivity
2011-09-01 16:32           ` Anthony Liguori
2011-09-02  8:35             ` Avi Kivity
2011-09-03 12:25               ` Blue Swirl
2011-09-02  0:38         ` David Gibson
2011-09-02  8:37         ` Avi Kivity
2011-09-03  3:04           ` Eduard - Gabriel Munteanu
2011-09-02  4:40       ` David Gibson
2011-09-03  1:16     ` Richard Henderson
2011-09-23 16:37   ` Anthony Liguori
2011-09-01  5:00 ` [Qemu-devel] [PATCH 02/10] rtl8139: Use PCI DMA stub functions David Gibson
2011-09-01  5:00 ` [Qemu-devel] [PATCH 03/10] eepro100: " David Gibson
2011-09-01  5:00 ` [Qemu-devel] [PATCH 04/10] ac97: " David Gibson
2011-09-01  5:00 ` [Qemu-devel] [PATCH 05/10] es1370: " David Gibson
2011-09-01  5:00 ` [Qemu-devel] [PATCH 06/10] e1000: " David Gibson
2011-09-01  5:01 ` [Qemu-devel] [PATCH 07/10] lsi53c895a: " David Gibson
2011-09-01  5:01 ` [Qemu-devel] [PATCH 08/10] pcnet-pci: " David Gibson
2011-09-01  5:01 ` [Qemu-devel] [PATCH 09/10] usb-ohci: " David Gibson
2011-09-01 10:10   ` Gerd Hoffmann
2011-09-02  1:47     ` David Gibson [this message]
2011-09-01  5:01 ` [Qemu-devel] [PATCH 10/10] intel-hda: " David Gibson
2011-09-01 10:16   ` Gerd Hoffmann
2011-09-02  1:42     ` David Gibson
2011-09-01 11:33 ` [Qemu-devel] [0/10] Preliminary work for IOMMU emulation support; the easy bits Eduard - Gabriel Munteanu
2011-09-02  0:36   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110902014752.GT11906@yookeroo.fritz.box \
    --to=dwg@au1.ibm.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=eduard.munteanu@linux360.ro \
    --cc=joerg.roedel@amd.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).