From: Alon Levy <alevy@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Brad <brad@comstyle.com>
Subject: Re: [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data
Date: Fri, 2 Sep 2011 13:45:12 +0300 [thread overview]
Message-ID: <20110902104512.GC27006@bow> (raw)
In-Reply-To: <20110902101032.GA23431@stefanha-thinkpad.localdomain>
On Fri, Sep 02, 2011 at 11:10:32AM +0100, Stefan Hajnoczi wrote:
> On Mon, Aug 22, 2011 at 01:34:57PM -0400, Brad wrote:
> > On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote:
> > > libcacard: use INSTALL_DATA for data
> > >
> > > Signed-off-by: Brad Smith <brad@comstyle.com>
> > >
> > > ---
> > > libcacard/Makefile | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/libcacard/Makefile b/libcacard/Makefile
> > > index 5cd7594..fe9747a 100644
> > > --- a/libcacard/Makefile
> > > +++ b/libcacard/Makefile
> > > @@ -54,7 +54,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient
> > > $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
> > > $(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> > > libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> > > - libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)"
> > > + libtool --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
> > > libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
> > > for inc in *.h; do \
> > > libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \
> > > --
> > > 1.7.6
> >
> > An updated diff against up to date master.
> >
> >
> > libcacard: use INSTALL_DATA for data
> >
> > Signed-off-by: Brad Smith <brad@comstyle.com>
> >
> > ---
> > libcacard/Makefile | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Thanks, applied to the trivial patches tree:
> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
>
Thanks, my bad for not doing a pull request.
> Stefan
>
next prev parent reply other threads:[~2011-09-02 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 21:23 [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data Brad
2011-08-13 0:04 ` Alon Levy
2011-08-22 17:34 ` Brad
2011-09-02 10:10 ` Stefan Hajnoczi
2011-09-02 10:45 ` Alon Levy [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-28 12:01 Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902104512.GC27006@bow \
--to=alevy@redhat.com \
--cc=brad@comstyle.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).